Skip to content

chore: reuse shared test utilities#87

Merged
chenjiahan merged 2 commits into
mainfrom
agent/use-shared-test-utils
Jul 13, 2026
Merged

chore: reuse shared test utilities#87
chenjiahan merged 2 commits into
mainfrom
agent/use-shared-test-utils

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Jul 13, 2026

Copy link
Copy Markdown
Member

This PR replaces the local test output cleanup helper with prepareDist from @rstackjs/test-utils, keeping common filesystem test behavior maintained in one package.

@chenjiahan chenjiahan marked this pull request as ready for review July 13, 2026 05:00
@coderabbitai

coderabbitai Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cc55e6a0-be72-4445-b03d-2453ecd44c5d

📥 Commits

Reviewing files that changed from the base of the PR and between 8205dce and 37c2664.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • package.json
  • pnpm-workspace.yaml
  • tests/prebundle.test.ts
📝 Walkthrough

Walkthrough

Added @rstackjs/test-utils as a development dependency and excluded the @rstackjs/* namespace from minimum release-age enforcement. Updated prebundle tests to use prepareDist during setup and teardown, removed the local directory-reset helper, and simplified filesystem imports.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the main change of reusing shared test utilities.
Description check ✅ Passed The description matches the changeset by describing the shared test utility swap and related filesystem behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/use-shared-test-utils

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan chenjiahan merged commit 77c9614 into main Jul 13, 2026
6 checks passed
@chenjiahan chenjiahan deleted the agent/use-shared-test-utils branch July 13, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@chenjiahan